D15530: kdev-clang : somewhat more complete ObjC(++) support

René J.V. Bertin noreply at phabricator.kde.org
Fri Sep 21 11:02:59 BST 2018

rjvbb added a comment.

  > You should probably also add a few lines to the `custom-definesandincludes` plugin.
  In a different review I presume?


> aaronpuchert wrote in parsesession.cpp:112-113
> This seems to be relevant for unit tests, why do you do the distinction here? I think it should be done down where my other comment is.

I didn't want to presume that parserSettings.parserOptions can never be empty for other reasons, and didn't want to change the logic completely where ObjC presence would override parserOptions.isEmpty() (which causes a return).

> aaronpuchert wrote in parsesession.cpp:137-141
> Maybe the time has come to make this a `switch` statement.

Maybe as a separate, later change, or is there already a state or language variable that is suitable an argument for a switch statement?

  R32 KDevelop


To: rjvbb, #kdevelop
Cc: aaronpuchert, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180921/6ecad54c/attachment.html>

More information about the KDevelop-devel mailing list