<table><tr><td style="">aaronpuchert added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15530">View Revision</a></tr></table><br /><div><div><p>You should probably also add a few lines to the <tt style="background: #ebebeb; font-size: 13px;">custom-definesandincludes</tt> plugin.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15530#inline-84384">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parsesession.cpp:112-113</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">objcOption</span> <span style="color: #aa2211">=</span> <span class="n">QByteArrayLiteral</span><span class="p">(</span><span style="color: #766510">"-xobjective-c++"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">parserSettings</span><span class="p">.</span><span class="n">parserOptions</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// The parserOptions can be empty for some unit tests that use ParseSession directly</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">auto</span> <span class="n">defaultArguments</span> <span style="color: #aa2211">=</span> <span class="n">ClangSettingsManager</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">parserSettings</span><span class="p">(</span><span class="n">path</span><span class="p">).</span><span class="n">toClangAPI</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This seems to be relevant for unit tests, why do you do the distinction here? I think it should be done down where my other comment is.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15530#inline-84382">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parsesession.cpp:137-141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">objcOption</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">       <span class="n">result</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">objcOption</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">       <span class="n">result</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">parserSettings</span><span class="p">.</span><span class="n">isCpp</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">QByteArrayLiteral</span><span class="p">(</span><span style="color: #766510">"-xc++"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span class="n">QByteArrayLiteral</span><span class="p">(</span><span style="color: #766510">"-xc"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe the time has come to make this a <tt style="background: #ebebeb; font-size: 13px;">switch</tt> statement.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15530">https://phabricator.kde.org/D15530</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop<br /><strong>Cc: </strong>aaronpuchert, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>