D15532: kdev-astyle : improved ObjC support

Kevin Funk noreply at phabricator.kde.org
Thu Sep 20 07:51:25 BST 2018

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.

  Please update the Diff according to our requests, then I think this can still go into 5.3 branch. Friedrich, you still agree this could go into 5.3? :)


> astyle_plugin.cpp:377
> +         return QLatin1String(formattingObjCSample);
> +         break;
> +      default:

No `break;` needed after return.

> astyle_plugin.cpp:380
> +         return QLatin1String(formattingCxxSample);
> +         break;
> +   }

Add a `Q_UNREACHABLE();` at the end of this function, as a small debugging aid.

  R32 KDevelop


To: rjvbb, #kdevelop, kossebau, kfunk
Cc: kfunk, pino, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180920/ddcede4e/attachment-0001.html>

More information about the KDevelop-devel mailing list