D15415: Port away from deprecated KFilterProxySearchLine
Anton Anikin
noreply at phabricator.kde.org
Tue Sep 11 07:21:30 BST 2018
antonanikin accepted this revision.
antonanikin added a comment.
This revision is now accepted and ready to land.
LGFM
INLINE COMMENTS
> filterproxysearchline.cpp:46
> +
> +FilterProxySearchLine::~FilterProxySearchLine() = default;
> +
What's about moving `default` into header?
> kdeproviderwidget.cpp:49
> QHBoxLayout* topLayout = new QHBoxLayout;
> - KFilterProxySearchLine* filterLine = new KFilterProxySearchLine(this);
> + FilterProxySearchLine* filterLine = new FilterProxySearchLine(this);
> KDEProjectsModel* model = new KDEProjectsModel(this);
maybe `auto filterLine = new ...` ? Less characters :)
REPOSITORY
R32 KDevelop
BRANCH
portawayfromfilteredit
REVISION DETAIL
https://phabricator.kde.org/D15415
To: kossebau, #kdevelop, antonanikin
Cc: antonanikin, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180911/a0545704/attachment-0001.html>
More information about the KDevelop-devel
mailing list