<table><tr><td style="">antonanikin accepted this revision.<br />antonanikin added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15415">View Revision</a></tr></table><br /><div><div><p>LGFM</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15415#inline-82917">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filterproxysearchline.cpp:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">FilterProxySearchLine</span><span style="color: #aa2211">::~</span><span class="n">FilterProxySearchLine</span><span class="p">()</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">default</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What's about moving <tt style="background: #ebebeb; font-size: 13px;">default</tt> into header?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15415#inline-82916">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdeproviderwidget.cpp:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QHBoxLayout</span><span style="color: #aa2211">*</span> <span class="n">topLayout</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QHBoxLayout</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">K</span>FilterProxySearchLine</span><span style="color: #aa2211">*</span> <span class="n">filterLine</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="bright"></span><span class="n"><span class="bright">K</span>FilterProxySearchLine</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">FilterProxySearchLine</span><span style="color: #aa2211">*</span> <span class="n">filterLine</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">FilterProxySearchLine</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">KDEProjectsModel</span><span style="color: #aa2211">*</span> <span class="n">model</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KDEProjectsModel</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe <tt style="background: #ebebeb; font-size: 13px;">auto filterLine = new ...</tt> ? Less characters :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>portawayfromfilteredit</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15415">https://phabricator.kde.org/D15415</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, antonanikin<br /><strong>Cc: </strong>antonanikin, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd<br /></div>