D14931: Eliminate duplicate QMaps in OutputWidget

Vyacheslav Korneev noreply at phabricator.kde.org
Sun Sep 2 10:20:37 BST 2018


vkorneev added a comment.


  Hi @kfunk, you've told that the patch looks good in general except for the redundant `m_views.remove(id);` call - I've deleted it. So what about the patch now? Should anything else be changed or can it be accepted now?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180902/978f4423/attachment.html>


More information about the KDevelop-devel mailing list