D14931: Eliminate duplicate QMaps in OutputWidget

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> outputwidget.cpp:527
>          }
> -        m_views[id] = listview;
> +        m_views[id].view = QSharedPointer<QTreeView>(listview);
>  

It's not correct, 3 line above you get a raw managed pointer, here you make a distinct managed pointer with same source. It'll result in double deletion when goes out of scope.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: anthonyfieroni, aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180902/83b4ab9e/attachment.html>