D11291: Do not add return type to constructors declaration when editing definition in signature assistant.
noreply at phabricator.kde.org
Tue Mar 13 17:13:57 UTC 2018
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Looks good to me, thanks!
> apol wrote in adaptsignatureassistant.cpp:59
> Only need to lock here, no? Or at least after the if.
Yeah but the macro is not a lock, just an assert. If you expect the function to be called with the lock, it IMO makes sense to put it on the top.
To: shashwatdixit, kfunk, mwolff, #kdevelop, brauch
Cc: brauch, apol, #kdevelop, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel