D11291: Do not add return type to constructors declaration when editing definition in signature assistant.

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Mar 13 17:11:05 UTC 2018


apol added inline comments.

INLINE COMMENTS

> adaptsignatureassistant.cpp:59
> +    if(funDef && funDef->hasDeclaration()) {
> +        auto funDec = funDef->declaration();
> +        auto classFun = dynamic_cast<const ClassFunctionDeclaration*>(funDec);

Only need to lock here, no? Or at least after the if.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D11291

To: shashwatdixit, kfunk, mwolff, #kdevelop
Cc: apol, #kdevelop, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180313/92822382/attachment.html>


More information about the KDevelop-devel mailing list