D14235: Fix QStringBuilder taking reference to temporary due to auto

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  This does fix https://bugs.kde.org/show_bug.cgi?id=394055, doesn't it? If so please reference it in the commit message.

INLINE COMMENTS

> kossebau wrote in completionhelper.cpp:81
> Any proposal for a comment to prevent someone "fixing" this into "auto" again?

Not sure if needed, one needs to pay attention to that when using `auto` combined with concatenating strings after all. At least clang-tidy will not /automatically/ transform this using `auto`.

REPOSITORY
  R32 KDevelop

BRANCH
  fixreftotempwithqstringbuilder

REVISION DETAIL
  https://phabricator.kde.org/D14235

To: kossebau, #kdevelop, shashwatdixit, mwolff, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180720/888a9ec2/attachment.html>