D14235: Fix QStringBuilder taking reference to temporary due to auto

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D14235#295161 <https://phabricator.kde.org/D14235#295161>, @kfunk wrote:
  
  > This does fix https://bugs.kde.org/show_bug.cgi?id=394055, doesn't it? If so please reference it in the commit message.
  
  
  No idea, will give it a check and if so, add the reference, okay. Thanks for review.

INLINE COMMENTS

> kfunk wrote in completionhelper.cpp:81
> Not sure if needed, one needs to pay attention to that when using `auto` combined with concatenating strings after all. At least clang-tidy will not /automatically/ transform this using `auto`.

Many people might not be aware of that trap with QStringBuilder and auto. Or know what QStringBuilder is at all, as it hides away usually.
One has to be bitten a few times before it's part of mental background code checking perhaps :)

And I was more thinking of "human" fixers who are in for code consistency or modern looking code (/me tries to look innocent) ;)

Okay, so being unsure I will leave that comment away for now, too much generalizing from ego perhaps :)

REPOSITORY
  R32 KDevelop

BRANCH
  fixreftotempwithqstringbuilder

REVISION DETAIL
  https://phabricator.kde.org/D14235

To: kossebau, #kdevelop, shashwatdixit, mwolff, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180720/04f677f4/attachment-0001.html>