D14235: Fix QStringBuilder taking reference to temporary due to auto
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Jul 19 22:54:14 BST 2018
kossebau added inline comments.
INLINE COMMENTS
> completionhelper.cpp:81
> auto templateTypes = templateParams(cursor);
> - auto param = QLatin1String("template<") + templateTypes.join(QStringLiteral(", ")) + QLatin1String("> class ") + paramName ;
> + QString param = QLatin1String("template<") + templateTypes.join(QStringLiteral(", ")) + QLatin1String("> class ") + paramName ;
> params.append(param);
Any proposal for a comment to prevent someone "fixing" this into "auto" again?
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D14235
To: kossebau, #kdevelop, shashwatdixit, mwolff
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180719/2c10d468/attachment.html>
More information about the KDevelop-devel
mailing list