D9956: Fix SVN history fetching and clean up plugin

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  I'm OK with this, but please split this up the next time. You could still have posted it as one review request, but splitting it up is always a good idea. It's a general coding mantra that you should start following, as it makes your life much easier in the long term.

INLINE COMMENTS

> svnjobbase.cpp:162
>      emitResult();
> -    if( m_status == VcsJob::JobCanceled ) {
> -        deleteLater();

not leaked when canceled? probably done from somewhere else?

REPOSITORY
  R32 KDevelop

BRANCH
  svnlog

REVISION DETAIL
  https://phabricator.kde.org/D9956

To: croick, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180118/cb574d4a/attachment.html>