D9956: Fix SVN history fetching and clean up plugin

[Christoph Roick]

croick added a comment.


  It might have been better to split the changes.
  On the other hand it seems nobody likes to spend much time on that plugin, so maybe doing it in one go is ok?

INLINE COMMENTS

> svndiffjob.cpp:342
>  
> -    internalJobDone();
>      emit resultsReady( this );

This one is called automatically and resulted in crashes.

> svnlogjob.cpp:117
>      connect( m_job, &SvnInternalLogJob::logEvent,
> -             this, &SvnLogJob::logEventReceived, Qt::QueuedConnection );
>  

Using a queued connection here, makes the notification for new log entries come too late.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9956

To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180118/e3f13330/attachment.html>