D9956: Fix SVN history fetching and clean up plugin
noreply at phabricator.kde.org
Thu Jan 18 00:37:23 UTC 2018
croick added a comment.
It might have been better to split the changes.
On the other hand it seems nobody likes to spend much time on that plugin, so maybe doing it in one go is ok?
> - internalJobDone();
> emit resultsReady( this );
This one is called automatically and resulted in crashes.
> connect( m_job, &SvnInternalLogJob::logEvent,
> - this, &SvnLogJob::logEventReceived, Qt::QueuedConnection );
Using a queued connection here, makes the notification for new log entries come too late.
To: croick, #kdevelop
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel