D9956: Fix SVN history fetching and clean up plugin

[Christoph Roick]

croick added a comment.


  In https://phabricator.kde.org/D9956#192766, @mwolff wrote:
  
  > I'm OK with this, but please split this up the next time. You could still have posted it as one review request, but splitting it up is always a good idea. It's a general coding mantra that you should start following, as it makes your life much easier in the long term.
  
  
  Theoretically I'm aware of that and try to further improve concerning that matter... Thanks for the review.

INLINE COMMENTS

> mwolff wrote in svnjobbase.cpp:162
> not leaked when canceled? probably done from somewhere else?

The docs (and the code of KJob) say, that emitResult() calls deleteLater() by default, not depending on the status.

REPOSITORY
  R32 KDevelop

BRANCH
  svnlog

REVISION DETAIL
  https://phabricator.kde.org/D9956

To: croick, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180118/8713d70e/attachment.html>