D9956: Fix SVN history fetching and clean up plugin
noreply at phabricator.kde.org
Thu Jan 18 21:15:17 UTC 2018
croick added a comment.
In https://phabricator.kde.org/D9956#192766, @mwolff wrote:
> I'm OK with this, but please split this up the next time. You could still have posted it as one review request, but splitting it up is always a good idea. It's a general coding mantra that you should start following, as it makes your life much easier in the long term.
Theoretically I'm aware of that and try to further improve concerning that matter... Thanks for the review.
> mwolff wrote in svnjobbase.cpp:162
> not leaked when canceled? probably done from somewhere else?
The docs (and the code of KJob) say, that emitResult() calls deleteLater() by default, not depending on the status.
To: croick, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel