D14931: Eliminate duplicate QMaps in OutputWidget

Vyacheslav Korneev noreply at phabricator.kde.org
Fri Aug 24 14:38:46 BST 2018

vkorneev added a comment.

  Hi @aaronpuchert, thank you for comment.
  I was in doubt between these two variants while writing the code and stopped on current one for two reasons:
  - Looking at QT source code, `reset()` is ultimately reduced to `QSharedPointer copy(t); swap(copy);` anyways. And QSharedPointer has move constructor, so it'll work in this case (right?).
  - Current variant better expresses my intentions (that's subjective).
  But if you still think that we should use `reset()` I'd change it in a moment. What do you think?
  P.S. Sorry for that nit-picking. I'm still just learning, so I have a time and desire to make these long investigations about whether it's better to use reset or assignment, shared pointers or raw pointers, etc. I think that'll pass after a few more patches XD

  R32 KDevelop


To: vkorneev, #kdevelop
Cc: aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180824/fc19cfe0/attachment.html>

More information about the KDevelop-devel mailing list