D14931: Eliminate duplicate QMaps in OutputWidget

Aaron Puchert noreply at phabricator.kde.org
Fri Aug 24 21:46:26 BST 2018

aaronpuchert added a comment.

  In D14931#314739 <https://phabricator.kde.org/D14931#314739>, @vkorneev wrote:
  > I was in doubt between these two variants while writing the code and stopped on current one for two reasons:
  > - Looking at QT source code, `reset()` is ultimately reduced to `QSharedPointer copy(t); swap(copy);` anyways. And QSharedPointer has move constructor, so it'll work in this case (right?).
  > - Current variant better expresses my intentions (that's subjective). But if you still think that we should use `reset()` I'd change it in a moment. What do you think?
  These were just suggestions. Using `reset` tends to be a bit shorter because you don't have to write the type name again.
  There should be no functional change between the two variants, at least I see none.

  R32 KDevelop


To: vkorneev, #kdevelop
Cc: aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180824/8c5bed69/attachment.html>

More information about the KDevelop-devel mailing list