D14931: Eliminate duplicate QMaps in OutputWidget

Aaron Puchert noreply at phabricator.kde.org
Thu Aug 23 23:55:16 BST 2018


aaronpuchert added inline comments.

INLINE COMMENTS

> outputwidget.cpp:286
> +            if (fview.proxyModel) {
> +                fview.proxyModel = QSharedPointer<QSortFilterProxyModel>();
> +                fview.filter = QString();

You can also write `fview.proxyModel.reset()`.

> outputwidget.cpp:527
>          }
> -        m_views[id] = listview;
> +        m_views[id].view = QSharedPointer<QTreeView>(listview);
>  

And here you can write `m_views[id].view.reset(listview)`.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: aaronpuchert, kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180823/883f1251/attachment.html>


More information about the KDevelop-devel mailing list