D8569: Fixed launch url composition from launch configuration server, path and arguments

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> executebrowserplugin.cpp:87
> +	}
> +	url.setUrl(host + path);
> +	QString q = grp.readEntry( ExecuteBrowserPlugin::argumentsEntry, "" );

Looks like something will be missing now, at least it won't be very backwards compatible. For "https://kde.org/index.html" the host used to be  "kde.org", now you are assuming that the schema is part of the host? Should we change the serverEntry definition to be the base url rather than the hostname?

REPOSITORY
  R67 KDevelop Execute Browser

REVISION DETAIL
  https://phabricator.kde.org/D8569

To: santilin
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171031/68512124/attachment.html>