D8569: Fixed launch url composition from launch configuration server, path and arguments
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Oct 31 11:45:35 UTC 2017
apol added inline comments.
> + }
> + url.setUrl(host + path);
> + QString q = grp.readEntry( ExecuteBrowserPlugin::argumentsEntry, "" );
Looks like something will be missing now, at least it won't be very backwards compatible. For "https://kde.org/index.html" the host used to be "kde.org", now you are assuming that the schema is part of the host? Should we change the serverEntry definition to be the base url rather than the hostname?
R67 KDevelop Execute Browser
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel