<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8569" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8569#inline-37305" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">executebrowserplugin.cpp:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">url</span><span class="p">.</span><span class="n">setUrl</span><span class="p">(</span><span class="n">host</span> <span style="color: #aa2211">+</span> <span class="n">path</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span class="n">QString</span> <span class="n">q</span> <span style="color: #aa2211">=</span> <span class="n">grp</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span> <span class="n">ExecuteBrowserPlugin</span><span style="color: #aa2211">::</span><span class="n">argumentsEntry</span><span class="p">,</span> <span style="color: #766510">""</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Looks like something will be missing now, at least it won't be very backwards compatible. For "<a href="https://kde.org/index.html"" class="remarkup-link" target="_blank" rel="noreferrer">https://kde.org/index.html"</a> the host used to be  "kde.org", now you are assuming that the schema is part of the host? Should we change the serverEntry definition to be the base url rather than the hostname?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R67 KDevelop Execute Browser</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8569" rel="noreferrer">https://phabricator.kde.org/D8569</a></div></div><br /><div><strong>To: </strong>santilin<br /><strong>Cc: </strong>apol, kdevelop-devel<br /></div>