D8156: Fix registration of the enabled state of plugins

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Oct 8 19:40:01 UTC 2017

kossebau added inline comments.


> mwolff wrote in test_pluginenabling.cpp:45
> personally I'd prefer separate test functions instead of ifdef. afaik you can de-init the shell completely nowadays (or not?). so you could have one test method for the default scenario, and another one for the custom plugins

Problem here is that we want to especially test the initial setup when plugincontroller is instantiated.
So it needs to be two different tests.

Would you prefer going for subclassing the test instead and doing the specialization there?
Personally would prefer the ifdef over that, as this way there is a one file to look at.
But as you prefer.

> mwolff wrote in test_pluginenabling.cpp:61
> if empty, remove those methods

Was copied over from some other test. Shall I then clean up the other tests as well from empty methods?

  R32 KDevelop


To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171008/a54665a2/attachment.html>

More information about the KDevelop-devel mailing list