D8156: Fix registration of the enabled state of plugins

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  awesome, thanks

INLINE COMMENTS

> test_pluginenabling.cpp:45
> +    AutoTestShell::init({
> +#ifdef CUSTOM_DEFAULT_PLUGINS
> +        // set those as default which would not be by own metadata

personally I'd prefer separate test functions instead of ifdef. afaik you can de-init the shell completely nowadays (or not?). so you could have one test method for the default scenario, and another one for the custom plugins

> test_pluginenabling.cpp:61
> +
> +void TestPluginEnabling::init()
> +{

if empty, remove those methods

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8156

To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171008/87938149/attachment-0001.html>