D7995: KDevelop: address dirwatching inefficiency (WIP/PoC)

René J.V. Bertin noreply at phabricator.kde.org
Thu Nov 23 18:59:31 UTC 2017

rjvbb added a comment.

  > on a more serious note: your crash probably arises from this being bound to the AFMP lifetime - it won't get disconnected when the watcher gets killed. You probably want to use `watcher` instead of `q` as third param here.
  All this discussion made me forget why I created a dedicated class in the first place and think could do away with the signal/slot mechanism.
  Correct me if I'm wrong, but that's probably not true: the dirwatcher can be fed from the main thread so we either need a locking mechanism or else we need to feed it only from the main thread.
  Using `watcher` as the target object should also prevent it from receiving signals after being deleted. I should have seen that myself (and it was probably a bug), doh.

  R32 KDevelop


To: rjvbb, #kdevelop, mwolff
Cc: aaronpuchert, arrowdodger, kfunk, dfaure, mwolff, brauch, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/b5e80017/attachment.html>

More information about the KDevelop-devel mailing list