D7995: KDevelop: address dirwatching inefficiency (WIP/PoC)

René J.V. Bertin noreply at phabricator.kde.org
Thu Nov 23 21:04:47 UTC 2017


rjvbb updated this revision to Diff 22858.
rjvbb added a comment.


  updated to fix the potential signal delivery to a stale watcher instance.
  
  This new approach watches only directories and will thus trigger a full reload of any directory in which something changed. It would be pointless and potentially counterproductive to do this just before all projects will be unloaded; prevent this by connecting `KDirWatch::stopScan()` to  `QCoreApplication::aboutToQuit`. This should be safe, right?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7995?vs=22667&id=22858

REVISION DETAIL
  https://phabricator.kde.org/D7995

AFFECTED FILES
  kdevplatform/project/CMakeLists.txt
  kdevplatform/project/abstractfilemanagerplugin.cpp
  kdevplatform/project/filemanagerlistjob.cpp
  kdevplatform/project/filemanagerlistjob.h
  kdevplatform/project/projectwatcher.cpp
  kdevplatform/project/projectwatcher.h
  kdevplatform/project/tests/abstractfilemanagerpluginimportbenchmark.cpp

To: rjvbb, #kdevelop, mwolff
Cc: aaronpuchert, arrowdodger, kfunk, dfaure, mwolff, brauch, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/ccecf5aa/attachment.html>


More information about the KDevelop-devel mailing list