D7995: KDevelop: address dirwatching inefficiency (WIP/PoC)

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> abstractfilemanagerplugin.cpp:153
> +    q->connect( listJob, &FileManagerListJob::watchDir,
> +                q, [item, watcher] (const QString& path) {
> +                    watcher->addDir(path); } );

on a more serious note: your crash probably arises from this being bound to the AFMP lifetime - it won't get disconnected when the watcher gets killed. You probably want to use `watcher` instead of `q` as third param here.

still, doesn't change the fact that the whole watcher wrapper should be removed

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7995

To: rjvbb, #kdevelop, mwolff
Cc: aaronpuchert, arrowdodger, kfunk, dfaure, mwolff, brauch, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/d73770d5/attachment.html>