D8954: kdevelop: prevent empty dockwidget context menuitems
René J.V. Bertin
noreply at phabricator.kde.org
Thu Nov 23 15:07:52 UTC 2017
rjvbb added a comment.
Take the outline toolview example. There I managed to do this and get a sensible menu entry for the filter widget of the toolview's toolbar. But as Kevin said, not all the concerned QActions can be represented in menus in a way that makes sense and for those the only proper text would be something like "this menu item doesn't do anything (don't ask why)".
I considered proposing to let such entries activate/unhide the toolbar and where relevant move focus to the widget, but there is already a toolbar control menu action.
A real proper fix would be a redesign that separates menu-compatible QActions from those that shouldn't appear in the context menu. Alternatively, implement the plugin method that returns the actions to be put in the context menu. But both fixes boil down to what is done now so I see nothing wrong with applying an equivalent filter at a shared, central location.
To: rjvbb, kfunk
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel