D8959: Make more signals non-const
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Nov 23 00:28:38 UTC 2017
kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
Not sure exactly what is wrong with const signals, besides
QMetaObject::activate(...) wanting a non-const this argument.
Collected signals are from a recent clazy run, so changing these will at least
result in less noisy future clazy run ;)
And perhaps consistency in general signal non-constness.
The Clazy const-signal-or-slot check docs only claims
"For signals, it's just pointless to mark them as const."
without giving any reasoning.
So dumping patch as RFC, to be either moved to /dev/null or applied.
REPOSITORY
R32 KDevelop
BRANCH
makesignalsnonconst
REVISION DETAIL
https://phabricator.kde.org/D8959
AFFECTED FILES
kdevplatform/interfaces/idocumentationprovider.h
kdevplatform/interfaces/idocumentationproviderprovider.h
kdevplatform/interfaces/itestcontroller.h
plugins/cmake/cmakedocumentation.h
plugins/debuggercommon/midebugsession.h
plugins/manpage/manpageplugin.h
plugins/qthelp/qthelpplugin.h
plugins/qthelp/qthelpproviderabstract.cpp
plugins/qthelp/qthelpproviderabstract.h
To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171123/4aa6dbb1/attachment-0001.html>
More information about the KDevelop-devel
mailing list