D8688: Create annotation color from revision hash, not RNG number
noreply at phabricator.kde.org
Tue Nov 7 00:20:11 UTC 2017
brauch added inline comments.
> kossebau wrote in vcsrevision.cpp:179
> Might be possible. Going via qHash(QString) was a helpless (and untested) try to have non-small integers, so that the bits used for the annotation color are not a null.
> But I have to admit I have no clear idea when such special revisions actually pop-up, and if they ever would be delivered for the annotations... guess I should add a TODO at least?
You hash the int anyways. I think qHash(3) is something with completely (predictively, of course) random bits, or at least it should be.
To: kossebau, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel