D8688: Create annotation color from revision hash, not RNG number

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> brauch wrote in vcsrevision.cpp:179
> can you simply return qHash<int>(revisionValue.value())?

Might be possible. Going via qHash(QString) was a helpless (and untested) try to have non-small integers, so that the bits used for the annotation color are not a null.

But I have to admit I have no clear idea when such special revisions actually pop-up, and if they ever would be delivered for the annotations... guess I should add a TODO at least?

REPOSITORY
  R32 KDevelop

BRANCH
  reproducableannotationcolor

REVISION DETAIL
  https://phabricator.kde.org/D8688

To: kossebau, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171107/6b5b4f30/attachment-0001.html>