D8688: Create annotation color from revision hash, not RNG number

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Nov 7 00:25:01 UTC 2017


kossebau added inline comments.

INLINE COMMENTS

> brauch wrote in vcsrevision.cpp:179
> You hash the int anyways. I think qHash(3) is something with completely (predictively, of course) random bits, or at least it should be.

Ah, sorry, my eyes are already closing being almost asleep, read you proposed just `return revisionValue.value()`.
Okay, then indeed something I agree to, will update.

REPOSITORY
  R32 KDevelop

BRANCH
  reproducableannotationcolor

REVISION DETAIL
  https://phabricator.kde.org/D8688

To: kossebau, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171107/e1fdf69b/attachment.html>


More information about the KDevelop-devel mailing list