D8569: Fixed launch url composition from launch configuration server, path and arguments

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Nov 3 13:25:22 UTC 2017


apol added a comment.


  you did fine ;)

INLINE COMMENTS

> santilin wrote in executebrowserplugin.cpp:87
> Yes, that was something odd with the old code. It added manually a fixed scheme part with url.setScheme("http"); so i guess you could not use https:// for your project.
> 
> Now, I assume the schema part is part of the host. Maybe we could change the label in the .ui
> 
> I wonder if with the old code you could open a url like  "https://kde.org/index.html", I bet that you could''t.

Probably not. Now if we need to go this way, it would probably make sense to use a different configuration setting, otherwise people will get weird URLs.

REPOSITORY
  R67 KDevelop Execute Browser

REVISION DETAIL
  https://phabricator.kde.org/D8569

To: santilin
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171103/0d15f29e/attachment.html>


More information about the KDevelop-devel mailing list