D8569: Fixed launch url composition from launch configuration server, path and arguments

[Santiago Capel Torres]

santilin added a comment.


  I have replied to @apol but I don't know how to submit the coment. I have 1 unsubmitted comment, but no way to submit it :(

INLINE COMMENTS

> apol wrote in executebrowserplugin.cpp:87
> Looks like something will be missing now, at least it won't be very backwards compatible. For "https://kde.org/index.html" the host used to be  "kde.org", now you are assuming that the schema is part of the host? Should we change the serverEntry definition to be the base url rather than the hostname?

Yes, that was something odd with the old code. It added manually a fixed scheme part with url.setScheme("http"); so i guess you could not use https:// for your project.

Now, I assume the schema part is part of the host. Maybe we could change the label in the .ui

I wonder if with the old code you could open a url like  "https://kde.org/index.html", I bet that you could''t.

REPOSITORY
  R67 KDevelop Execute Browser

REVISION DETAIL
  https://phabricator.kde.org/D8569

To: santilin
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171103/5364a38e/attachment-0001.html>