D5122: Allow users to install via a custom root installation command
Geetam Chawla
noreply at phabricator.kde.org
Sun May 7 12:40:49 UTC 2017
geetamc added a comment.
In https://phabricator.kde.org/D5122#107479, @zhigalin wrote:
> Hello and thanks for your effort.
> Just a few considerations:
>
> - When you edit an UI file, make sure not to forget to increase it's version
> - You also forgot to bind `kcfg_suCommand.enabled(bool)` to `kcfg_installAsRoot.toggled(bool)`
> - You must use QStringLiteral, not just plain strings
> - Try placing less newlines around
Thanks a lot for your suggestions!
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D5122
To: geetamc, kfunk, zhigalin
Cc: zhigalin, ltoscano, ematirov, kfunk, brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170507/3adbd5c8/attachment.html>
More information about the KDevelop-devel
mailing list