<table><tr><td style="">geetamc added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5122" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5122#107479" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel="noreferrer">D5122#107479</a>, <a href="https://phabricator.kde.org/p/zhigalin/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@zhigalin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Hello and thanks for your effort.<br />
 Just a few considerations:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">When you edit an UI file, make sure not to forget to increase it's version</li>
<li class="remarkup-list-item">You also forgot to bind <tt style="background: #ebebeb; font-size: 13px;">kcfg_suCommand.enabled(bool)</tt> to <tt style="background: #ebebeb; font-size: 13px;">kcfg_installAsRoot.toggled(bool)</tt></li>
<li class="remarkup-list-item">You must use QStringLiteral, not just plain strings</li>
<li class="remarkup-list-item">Try placing less newlines around</li>
</ul></div>
</blockquote>

<p>Thanks a lot for your suggestions!</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5122" rel="noreferrer">https://phabricator.kde.org/D5122</a></div></div><br /><div><strong>To: </strong>geetamc, kfunk, zhigalin<br /><strong>Cc: </strong>zhigalin, ltoscano, ematirov, kfunk, brauch, kdevelop-devel, KDevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>