D5044: Move "Analyze" menu items into "Code" menu

Anton Anikin noreply at phabricator.kde.org
Fri Mar 17 10:39:55 UTC 2017


antonanikin added inline comments.

INLINE COMMENTS

> kossebau wrote in plugin.cpp:61
> Could this action text (and similar for the other checks) be reduced to just "Cppcheck", like done with the context actions?
> That would remove all the duplicated "Analyze Current File With" which makes the menu more complex (more stuff to read).
> And the same action could be reused again for both toplevel menu and context menu.
> 
> What was the motivation to have different menu texts and thus QAction objects?

> Could this action text (and similar for the other checks) be reduced to just "Cppcheck", like done with the context actions?

Name reduction will be great at menu but then we will have two actions with same name but with different mean (file/project analysis) in shortcuts editor :( Do you have an ideas how to fix this with "right way"?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5044

To: antonanikin, #kdevelop, apol
Cc: kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170317/6e39f573/attachment-0001.html>


More information about the KDevelop-devel mailing list