D5044: Move "Analyze" menu items into "Code" menu

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> plugin.cpp:61
>  
> -    m_actionFile = new QAction(QIcon::fromTheme("cppcheck"), i18n("Cppcheck (Current File)"), this);
> -    connect(m_actionFile, &QAction::triggered, [this](){
> +    m_menuActionFile = new QAction(QIcon::fromTheme("cppcheck"), i18n("Analyze Current File with Cppcheck"), this);
> +    connect(m_menuActionFile, &QAction::triggered, [this]() {

Could this action text (and similar for the other checks) be reduced to just "Cppcheck", like done with the context actions?
That would remove all the duplicated "Analyze Current File With" which makes the menu more complex (more stuff to read).
And the same action could be reused again for both toplevel menu and context menu.

What was the motivation to have different menu texts and thus QAction objects?

> plugin.cpp:72
> +
> +    m_menuActionProject = new QAction(QIcon::fromTheme("cppcheck"), i18n("Analyze Current Project with Cppcheck"), this);
> +    connect(m_menuActionProject, &QAction::triggered, [this]() {

See first comment.

> kdevelopui.rc:111
> +    <Menu name="analyze_file">
> +      <text name="@title:menu">Analyze Current File</text>
> +      <Merge />

Given the comment above. this here then would be "Analyze Current File With"

> kdevelopui.rc:115
> +    <Menu name="analyze_project">
> +      <text name="@title:menu">Analyze Current Project</text>
> +      <Merge />

s.a.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5044

To: antonanikin, #kdevelop, apol
Cc: kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170315/c9db34a5/attachment.html>