D5044: Move "Analyze" menu items into "Code" menu

[Milian Wolff]

mwolff added subscribers: dfaure, mwolff.
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  @dfaure Is there a way to give actions in the "configure shortcuts" action a different name from what is shown by menus?

INLINE COMMENTS

> plugin.cpp:73
> +    m_menuActionProject = new QAction(QIcon::fromTheme("cppcheck"), i18n("Analyze Current Project with Cppcheck"), this);
> +    connect(m_menuActionProject, &QAction::triggered, [this]() {
> +        runCppcheck(true);

missing third argument "this"

> plugin.cpp:79
> +    m_contextActionProject = new QAction(QIcon::fromTheme("cppcheck"), i18n("Cppcheck"), this);
> +    connect(m_contextActionProject, &QAction::triggered, [this]() {
>          runCppcheck(true);

missing third argument "this"

> plugin.cpp:251
> +        m_contextActionProjectItem->disconnect();
> +        connect(m_contextActionProjectItem, &QAction::triggered, [this, item](){
>              runCppcheck(item->project(), item->path().toLocalFile());

missing third argument "this"

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5044

To: antonanikin, #kdevelop, apol, mwolff
Cc: mwolff, dfaure, kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170319/d0df3705/attachment.html>