D4981: patchreview : allow choice of the number of context lines

[René J.V. Bertin]

rjvbb updated this revision to Diff 12373.
rjvbb marked 10 inline comments as done.
rjvbb added a comment.


  new revision incorporating most suggested changes.
  
  I've implemented my own suggestion to add a contextLines variable with setter (and getter, to be complete) for `VCSDiffUpdater`. I think the same approach for `IBasicVersionControl` would reduce the complexity or at least the amount of changes. A priori the patchreview toolview could set the desired number of contextlines, and that parameter would then no longer need to be passed down through possibly multiple function calls; it'd be available in those backends that decide to (can) support the feature.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4981?vs=12325&id=12373

REVISION DETAIL
  https://phabricator.kde.org/D4981

AFFECTED FILES
  plugins/bazaar/bazaarplugin.cpp
  plugins/bazaar/bazaarplugin.h
  plugins/cvs/cvsplugin.cpp
  plugins/cvs/cvsplugin.h
  plugins/git/gitplugin.cpp
  plugins/git/gitplugin.h
  plugins/git/tests/test_git.cpp
  plugins/patchreview/patchreview.cpp
  plugins/patchreview/patchreview.h
  plugins/patchreview/patchreview.ui
  plugins/patchreview/patchreviewtoolview.cpp
  plugins/perforce/perforceplugin.cpp
  plugins/perforce/perforceplugin.h
  plugins/subversion/kdevsvnplugin.cpp
  plugins/subversion/kdevsvnplugin.h
  vcs/interfaces/ibasicversioncontrol.h
  vcs/interfaces/ipatchsource.h
  vcs/widgets/vcsdiffpatchsources.cpp
  vcs/widgets/vcsdiffpatchsources.h

To: rjvbb, kfunk, #kdevelop
Cc: kfunk, apol, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170310/77eb1e5f/attachment.html>