<table><tr><td style="">rjvbb updated this revision to Diff 12373.<br />rjvbb marked 10 inline comments as done.<br />rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4981" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>new revision incorporating most suggested changes.</p>

<p>I've implemented my own suggestion to add a contextLines variable with setter (and getter, to be complete) for <tt style="background: #ebebeb; font-size: 13px;">VCSDiffUpdater</tt>. I think the same approach for <tt style="background: #ebebeb; font-size: 13px;">IBasicVersionControl</tt> would reduce the complexity or at least the amount of changes. A priori the patchreview toolview could set the desired number of contextlines, and that parameter would then no longer need to be passed down through possibly multiple function calls; it'd be available in those backends that decide to (can) support the feature.</p></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D4981?vs=12325&id=12373" rel="noreferrer">https://phabricator.kde.org/D4981?vs=12325&id=12373</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4981" rel="noreferrer">https://phabricator.kde.org/D4981</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/bazaar/bazaarplugin.cpp<br />
plugins/bazaar/bazaarplugin.h<br />
plugins/cvs/cvsplugin.cpp<br />
plugins/cvs/cvsplugin.h<br />
plugins/git/gitplugin.cpp<br />
plugins/git/gitplugin.h<br />
plugins/git/tests/test_git.cpp<br />
plugins/patchreview/patchreview.cpp<br />
plugins/patchreview/patchreview.h<br />
plugins/patchreview/patchreview.ui<br />
plugins/patchreview/patchreviewtoolview.cpp<br />
plugins/perforce/perforceplugin.cpp<br />
plugins/perforce/perforceplugin.h<br />
plugins/subversion/kdevsvnplugin.cpp<br />
plugins/subversion/kdevsvnplugin.h<br />
vcs/interfaces/ibasicversioncontrol.h<br />
vcs/interfaces/ipatchsource.h<br />
vcs/widgets/vcsdiffpatchsources.cpp<br />
vcs/widgets/vcsdiffpatchsources.h</div></div></div><br /><div><strong>To: </strong>rjvbb, kfunk, KDevelop<br /><strong>Cc: </strong>kfunk, apol, kdevelop-devel, KDevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>