D4981: patchreview : allow choice of the number of context lines

René J.V. Bertin noreply at phabricator.kde.org
Fri Mar 10 20:26:11 UTC 2017


rjvbb updated this revision to Diff 12374.
rjvbb added a comment.


  I've had some time on my hand, so here's a version of the patch that implements the idea setters in `IBasicVersionControl` and `iPatchSource` instead of handing down the contextLines argument via function arguments.
  
  This makes the patch about 100 lines shorter, possibly more if I drop the changes to some of the VCS plugins.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4981?vs=12373&id=12374

REVISION DETAIL
  https://phabricator.kde.org/D4981

AFFECTED FILES
  plugins/bazaar/bazaarplugin.cpp
  plugins/cvs/cvsplugin.cpp
  plugins/cvs/cvsplugin.h
  plugins/git/gitplugin.cpp
  plugins/patchreview/patchreview.cpp
  plugins/patchreview/patchreview.h
  plugins/patchreview/patchreview.ui
  plugins/patchreview/patchreviewtoolview.cpp
  plugins/perforce/perforceplugin.cpp
  plugins/subversion/kdevsvnplugin.cpp
  vcs/interfaces/ibasicversioncontrol.h
  vcs/interfaces/ipatchsource.h
  vcs/widgets/vcsdiffpatchsources.cpp
  vcs/widgets/vcsdiffpatchsources.h

To: rjvbb, kfunk, #kdevelop
Cc: kfunk, apol, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170310/aa94649b/attachment.html>


More information about the KDevelop-devel mailing list