D6838: Fix duplicated annotation context menus & entries on repeated border show
noreply at phabricator.kde.org
Mon Jul 31 18:08:19 UTC 2017
brauch requested changes to this revision.
brauch added a comment.
This revision now requires changes to proceed.
Hm, yes, it seems plausible to me that we need to do something like this ... I wonder though, wouldn't it be better if KTE took ownership of the model passed in, and deleted it when the border was hidden?
> this, SLOT(annotationContextMenuAboutToShow(KTextEditor::View*,QMenu*,int)));
> + connect(doc->activeTextView(), SIGNAL(annotationBorderVisibilityChanged(View*,bool)),
> + this, SLOT(removeAnnotationModel(View*,bool)));
Why do you use string-based connect here...?
I think you can simply qobject_cast the view to AnnotationViewInterface* and use the modern function-pointer variant.
To: kossebau, #kdevelop, brauch
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel