<table><tr><td style="">brauch requested changes to this revision.<br />brauch added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6838" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hm, yes, it seems plausible to me that we need to do something like this ... I wonder though, wouldn't it be better if KTE took ownership of the model passed in, and deleted it when the border was hidden?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6838#inline-28634" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">vcspluginhelper.cpp:397</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">annotationContextMenuAboutToShow</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">View</span><span style="color: #aa2211">*</span><span class="p">,</span><span class="n">QMenu</span><span style="color: #aa2211">*</span><span class="p">,</span><span style="color: #aa4000">int</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">connect</span><span class="p">(</span><span class="n">doc</span><span style="color: #aa2211">-></span><span class="n">activeTextView</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">annotationBorderVisibilityChanged</span><span class="p">(</span><span class="n">View</span><span style="color: #aa2211">*</span><span class="p">,</span><span style="color: #aa4000">bool</span><span class="p">)),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">removeAnnotationModel</span><span class="p">(</span><span class="n">View</span><span style="color: #aa2211">*</span><span class="p">,</span><span style="color: #aa4000">bool</span><span class="p">)));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why do you use string-based connect here...?<br />
I think you can simply qobject_cast the view to AnnotationViewInterface* and use the modern function-pointer variant.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6838" rel="noreferrer">https://phabricator.kde.org/D6838</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop, brauch<br /><strong>Cc: </strong>kdevelop-devel<br /></div>