D6838: Fix duplicated annotation context menus & entries on repeated border show

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Handler of annotationContextMenuAboutToShow was not disconnected,
  thus accumulating connect calls and that way repeated addition
  of on-the-fly-created actions "Copy Revision" & "History...".
  
  Patch also fixes document-lifetime leakage of VcsAnnotationModel instances,
  where used once were never deleted once the annotation border had been
  removed again.

TEST PLAN
  Before on multiple hide and show of the annotation border for the same
  document the two actions mentioned above were duplicated by times of
  shown border. With this patch they no longer are. No sideeffects seen.

REPOSITORY
  R33 KDevPlatform

BRANCH
  fixDuplicatedAnnotationMenuEntries

REVISION DETAIL
  https://phabricator.kde.org/D6838

AFFECTED FILES
  vcs/vcspluginhelper.cpp
  vcs/vcspluginhelper.h

To: kossebau, #kdevelop, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170722/d64b7873/attachment.html>