[Differential] [Commented On] D4250: Add :vsplit and :split support in kdevelop

[Milian Wolff]

mwolff added a comment.


  I also wonder about the re-parenting, otherwise lgtm except for the minor style issue

INLINE COMMENTS

> ktexteditorpluginintegration.cpp:341
>  
> +void MainWindow::splitView(Qt::Orientation orientation){
> +    m_mainWindow->d->split(orientation);

style: put { on its own line

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: head7, brauch
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170123/826c62db/attachment.html>