[Differential] [Commented On] D4250: Add :vsplit and :split support in kdevelop

[Laurent George]

head7 added inline comments.

INLINE COMMENTS

> brauch wrote in ktexteditorpluginintegration.cpp:215
> Why is this required now?

In ktexteditor:src/utils/mainwindow.cpp splitView() function we have

  QMetaObject::invokeMethod(parent()
                            , "splitView"
                            , Qt::DirectConnection
                            , Q_ARG(Qt::Orientation, orientation));

and this function is called from AppCommands::exec (ktexteditor:src/vimode/appcommand.cpp) on the pointer mainWin:

  mainWin->splitView(Qt::Horizontal);

which is view->mainWindow() (the same kteView->mainWindow() above), so in my understanding we are then calling invokemethod on  kteView->mainWindow()->parent()  but this pointer was a nullptr, so I set it to the "correct" mainWindow object (this) when creating the wrapped view, but it's maybee not the best way to proceed ?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: head7, brauch
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170123/e16ee716/attachment.html>