[Differential] [Updated] D4250: Add :vsplit and :split support in kdevelop

Sven Brauch noreply at phabricator.kde.org
Sun Jan 22 22:58:23 UTC 2017


brauch added a comment.


  One question below, otherwise very nice change, and very compact :)

INLINE COMMENTS

> ktexteditorpluginintegration.cpp:215
>          if (auto kteView = toKteView(view)) {
> +            kteView->mainWindow()->setParent(this);
>              emit m_interface->viewCreated(kteView);

Why is this required now?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: head7, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170122/099c6701/attachment-0001.html>


More information about the KDevelop-devel mailing list