D5491: Improve detection of builtin defines from compiler command

[Sergey Kalinichev]

skalinichev added inline comments.

INLINE COMMENTS

> arichardson wrote in gcclikecompiler.cpp:115
> Can multiple threads call GccLikeCompiler::defines() at the same time? If so we would need a mutex to protect `m_definesIncludes` to avoid data corruption

This code should be used from main thread only, because caller code is not thread safe (project model is used IIRC)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5491

To: arichardson, #kdevelop, kfunk, mwolff
Cc: skalinichev, aaronpuchert, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170418/6977d7e0/attachment.html>