D5491: Improve detection of builtin defines from compiler command

[Alex Richardson]

arichardson added inline comments.

INLINE COMMENTS

> aaronpuchert wrote in gcclikecompiler.cpp:63
> My understanding is that it must start with "CL", not "cl". (https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/clCompileProgram.html#id-1.6.18)

I just looked at what clang accepts, and there are probably some build systems that use it lower case. I don't think it does any harm to also accept it lowercase but I don't mind removing it.

> mwolff wrote in gcclikecompiler.cpp:103
> does this need to be a warning?

It should of course only be a debug message (or completely silent if you prefer)

> mwolff wrote in gcclikecompiler.cpp:115
> ? what are you worried about here?

Can multiple threads call GccLikeCompiler::defines() at the same time? If so we would need a mutex to protect `m_definesIncludes` to avoid data corruption

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5491

To: arichardson, #kdevelop, kfunk, mwolff
Cc: aaronpuchert, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170418/772de59e/attachment.html>