D5491: Improve detection of builtin defines from compiler command

[Aaron Puchert]

aaronpuchert added inline comments.

INLINE COMMENTS

> arichardson wrote in gcclikecompiler.cpp:63
> I just looked at what clang accepts, and there are probably some build systems that use it lower case. I don't think it does any harm to also accept it lowercase but I don't mind removing it.

I think that depends on whether we want full compatibility with Clang or rather stick to the OpenCL standard. I think sticking to the standard is generally the safer bet, since Clang might decide to change this anytime, but the standard won't change.

I found over the years that cross-platform development is easiest when sticking close to standards and having tools that strictly enforce the standards instead of being permissive.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5491

To: arichardson, #kdevelop, kfunk, mwolff
Cc: skalinichev, aaronpuchert, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170418/f40a0f8c/attachment-0001.html>