[Differential] [Request, 71 lines] D3512: Show uses for __call__() and __{get,set}item__()

[flherne (Francis Herne)]

flherne created this revision.
flherne added a reviewer: brauch.
flherne set the repository for this revision to rKDEVPYTHON KDev-python.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Uses of __getitem__() and __setitem__() weren't shown at all.
  Uses of __call__() were incorrectly shown as uses of __init__().
  
  This removes ExpressionAst::belongsToCall, because it's always equal to ExpressionAst::parent or null.
  
  TODO: UseBuilder::visitName() needs tidying, and the new argument to functionDeclarationForCalledDeclaration() - can I rename that to something shorter, please?! - could be used elsewhere; possibly to make ExpressionBuilder::visitCall() simpler.
  If this approach looks sane, I'll carry on and post an updated version.

TEST PLAN
  No test regressions. No new tests, because I don't know how.
  Doesn't seem to crash.

REPOSITORY
  rKDEVPYTHON KDev-python

REVISION DETAIL
  https://phabricator.kde.org/D3512

AFFECTED FILES
  duchain/helpers.cpp
  duchain/helpers.h
  duchain/usebuilder.cpp
  duchain/usebuilder.h
  parser/ast.cpp
  parser/ast.h
  parser/generated.h
  parser/python35.sdef

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161125/0857362a/attachment.html>